Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH v2] Make zpty module work in the cygwin and msys2

X-seq: zsh-workers 47836
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: "zsh-workers@xxxxxxx" <zsh-workers@xxxxxxx>
Cc: Peiyuan Song <squallatf@xxxxxxxxx>
Subject: Re: [PATCH v2] Make zpty module work in the cygwin and msys2
Date: Sat, 16 Jan 2021 10:34:31 -0800
Archived-at: <https://zsh.org/workers/47836>
Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-01/CAH%2Bw%3D7aAYKWc80GKC_cwuZJFgY-aeD1TXHGgekMagmYX_sw75g%40mail.gmail.com>
In-reply-to: <CAE0YKFuSTc1Rt4c4ySAMfWPmb0hu6tFNd0ScHrOgAHUtvxyT9g@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAE0YKFuSTc1Rt4c4ySAMfWPmb0hu6tFNd0ScHrOgAHUtvxyT9g@mail.gmail.com>

On Thu, Jan 14, 2021 at 8:30 PM Peiyuan Song <squallatf@xxxxxxxxx> wrote:
>
> v2 change:  make fdtable[master]

I don't see anything technically wrong with this, but it does
duplicate the code for check_fd_table.

Anyone else have thoughts?  Can someone else who compiles on cygwin
give this a once-over?

Follow-Ups:
- Re: [PATCH v2] Make zpty module work in the cygwin and msys2
  - From: Peiyuan Song

References:
- [PATCH v2] Make zpty module work in the cygwin and msys2
  - From: Peiyuan Song

Messages sorted by: Reverse Date, Date, Thread, Author