Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH v2] Make zpty module work in the cygwin and msys2

X-seq: zsh-workers 47848
From: Peiyuan Song <squallatf@xxxxxxxxx>
To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
Cc: "zsh-workers@xxxxxxx" <zsh-workers@xxxxxxx>
Subject: Re: [PATCH v2] Make zpty module work in the cygwin and msys2
Date: Tue, 19 Jan 2021 09:52:23 +0800
Archived-at: <https://zsh.org/workers/47848>
Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-01/CAE0YKFt1R9uLFTbs2GvfqerGWCEkuJicAG8%2B2nu0JKeuDC%2BvYg%40mail.gmail.com>
In-reply-to: <CAH+w=7aAYKWc80GKC_cwuZJFgY-aeD1TXHGgekMagmYX_sw75g@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAE0YKFuSTc1Rt4c4ySAMfWPmb0hu6tFNd0ScHrOgAHUtvxyT9g@mail.gmail.com> <CAH+w=7aAYKWc80GKC_cwuZJFgY-aeD1TXHGgekMagmYX_sw75g@mail.gmail.com>

Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> 于2021年1月17日周日 上午2:34写道：
>
> On Thu, Jan 14, 2021 at 8:30 PM Peiyuan Song <squallatf@xxxxxxxxx> wrote:
> >
> > v2 change:  make fdtable[master]
>
> I don't see anything technically wrong with this, but it does
> duplicate the code for check_fd_table.
>
> Anyone else have thoughts?  Can someone else who compiles on cygwin
> give this a once-over?

I have upload v3 patch, remove duplicate the code for check_fd_table,
use addmodulefd api. assume cygwin upstream issue will be fixed in
version 3.2.0

References:
- [PATCH v2] Make zpty module work in the cygwin and msys2
  - From: Peiyuan Song
- Re: [PATCH v2] Make zpty module work in the cygwin and msys2
  - From: Bart Schaefer

Messages sorted by: Reverse Date, Date, Thread, Author