Possible issue with Completion/Unix/Type/_date

Possible issue with Completion/Unix/Type/_date_formats return value

X-seq: zsh-workers 47856

From: Jacob Menke <linux.dev25@xxxxxxxxx>

To: zsh-workers@xxxxxxx

Subject: Possible issue with Completion/Unix/Type/_date_formats return value

Date: Wed, 20 Jan 2021 17:43:31 -0500

Archived-at: <https://zsh.org/workers/47856>

Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-01/CAB5oL3Z_-jwbGuVWOLrkYmZdUpJbAhJ9aUN6MBdRBY1f9BZR1A%40mail.gmail.com>

List-id: <zsh-workers.zsh.org>

Hello,

I was wondering if _date_formats has an improper return value.

When called from _date (when $1 is unset, thus $1 == zsh is false) _date_formats always returns 1 even when matches are generated from _describe. This causes completion to continue erroneously.

Last two lines are shown:

_describe -t date-format-specifier 'date format specifier' specs \
-p "${(Q)PREFIX:-%}" -S ''
[[ $1 == zsh ]] && _message -e date-format-precision 'precision for %%. (1-9)'

I believe the return value of _describe should be returned either by making _describe last statement or storing its value in local var ret and then returning ret.

Thanks,

Jacob Menke

Reverse Date

Date

Thread

Author