Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Possible issue with Completion/Unix/Type/_date_formats return value

X-seq: zsh-workers 47878
From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
To: Jacob Menke <linux.dev25@xxxxxxxxx>
Cc: zsh-workers@xxxxxxx
Subject: Re: Possible issue with Completion/Unix/Type/_date_formats return value
Date: Tue, 26 Jan 2021 23:37:38 +0000
Archived-at: <https://zsh.org/workers/47878>
Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-01/20210126233738.GB25751%40tarpaulin.shahaf.local2>
In-reply-to: <CAB5oL3Z_-jwbGuVWOLrkYmZdUpJbAhJ9aUN6MBdRBY1f9BZR1A@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAB5oL3Z_-jwbGuVWOLrkYmZdUpJbAhJ9aUN6MBdRBY1f9BZR1A@mail.gmail.com>

Jacob Menke wrote on Wed, Jan 20, 2021 at 17:43:31 -0500:
> Hello,
> 
> I was wondering if _date_formats has an improper return value.
> 
> When called from _date (when $1 is unset, thus $1 == zsh is
> false) _date_formats always returns 1 even when matches are generated from
> _describe.  This causes completion to continue erroneously.
> 
> Last two lines are shown:
> _describe -t date-format-specifier 'date format specifier' specs 
>     -p "${(Q)PREFIX:-%}" -S ''
> [[ $1 == zsh ]] && _message -e date-format-precision 'precision for %%.(1-9)'
> 
> I believe the return value of _describe should be returned either by making
> _describe last statement or storing its value in local var ret and then
> returning ret.

Thanks for the report and sorry for the late answer.  I agree that it's wrong
as it stands.  Anyone wants to take it from here?

Follow-Ups:
- Re: Possible issue with Completion/Unix/Type/_date_formats return value
  - From: Jacob Menke

References:
- Possible issue with Completion/Unix/Type/_date_formats return value
  - From: Jacob Menke

Messages sorted by: Reverse Date, Date, Thread, Author