Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Remove redundancies from `git` completion

X-seq: zsh-workers 49332
From: Marlon Richert <marlon.richert@xxxxxxxxx>
To: Mikael Magnusson <mikachu@xxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] Remove redundancies from `git` completion
Date: Mon, 30 Aug 2021 15:34:26 +0300
Archived-at: <https://zsh.org/workers/49332>
In-reply-to: <CAHYJk3SpQ1KibJtbjOvEputdVL3XEeJywKewk-xxEgZxgLXowg@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAHLkEDt9=VdVFqvvwUfXb8HBO_uxZAnaS7f_gtBTSHy_XLMWsg@mail.gmail.com> <CAHYJk3SpQ1KibJtbjOvEputdVL3XEeJywKewk-xxEgZxgLXowg@mail.gmail.com>

On Mon, Aug 30, 2021 at 2:41 PM Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
>
> On 8/30/21, Marlon Richert <marlon.richert@xxxxxxxxx> wrote:
> > By the way: Why is there a `(( $+functions[_git-XXX] )) ||` statement
> > in front of each function inside Completion/Unix/Command/_git ? Can
> > those be removed?
>
> They are there so that you can override their implementation easily.

Is that documented somewhere?

And for purposes of overriding, wouldn't it be cleaner to simply
supply all sub-functions as separate #autoload files?

Follow-Ups:
- Re: [PATCH] Remove redundancies from `git` completion
  - From: Mikael Magnusson

References:
- [PATCH] Remove redundancies from `git` completion
  - From: Marlon Richert
- Re: [PATCH] Remove redundancies from `git` completion
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author