Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Remove redundancies from `git` completion

X-seq: zsh-workers 49333
From: Mikael Magnusson <mikachu@xxxxxxxxx>
To: Marlon Richert <marlon.richert@xxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] Remove redundancies from `git` completion
Date: Mon, 30 Aug 2021 14:42:25 +0200
Archived-at: <https://zsh.org/workers/49333>
In-reply-to: <CAHLkEDtu9ABHKC4JXn9s3DkKvh7me=s1x=EBV3ibr+dnUwbj9w@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAHLkEDt9=VdVFqvvwUfXb8HBO_uxZAnaS7f_gtBTSHy_XLMWsg@mail.gmail.com> <CAHYJk3SpQ1KibJtbjOvEputdVL3XEeJywKewk-xxEgZxgLXowg@mail.gmail.com> <CAHLkEDtu9ABHKC4JXn9s3DkKvh7me=s1x=EBV3ibr+dnUwbj9w@mail.gmail.com>

On 8/30/21, Marlon Richert <marlon.richert@xxxxxxxxx> wrote:
> On Mon, Aug 30, 2021 at 2:41 PM Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
>>
>> On 8/30/21, Marlon Richert <marlon.richert@xxxxxxxxx> wrote:
>> > By the way: Why is there a `(( $+functions[_git-XXX] )) ||` statement
>> > in front of each function inside Completion/Unix/Command/_git ? Can
>> > those be removed?
>>
>> They are there so that you can override their implementation easily.
>
> Is that documented somewhere?

Not explicitly, afaik.

> And for purposes of overriding, wouldn't it be cleaner to simply
> supply all sub-functions as separate #autoload files?

I don't think anyone is interested in maintaining 285 separate
completer files for git :).

-- 
Mikael Magnusson

Follow-Ups:
- Re: [PATCH] Remove redundancies from `git` completion
  - From: Marlon Richert

References:
- [PATCH] Remove redundancies from `git` completion
  - From: Marlon Richert
- Re: [PATCH] Remove redundancies from `git` completion
  - From: Mikael Magnusson
- Re: [PATCH] Remove redundancies from `git` completion
  - From: Marlon Richert

Messages sorted by: Reverse Date, Date, Thread, Author