Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: ZSH performance regression in 5.8.1.2-test

X-seq: zsh-workers 50109
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: ZSH performance regression in 5.8.1.2-test
Date: Tue, 26 Apr 2022 17:33:49 -0700
Archived-at: <https://zsh.org/workers/50109>
In-reply-to: <1592299421.100566.1650961915601@mail2.virginmedia.com>
List-id: <zsh-workers.zsh.org>
References: <CAHDOzW6wE2aP6-MMrBNAUYttzQwi2VC_OY7tJDwkQwrtp47zEQ@mail.gmail.com> <CAH+w=7YwV=Cu1N7dSb417R1Q0vAMu6R6hAryXqE4RBkmU_w5gA@mail.gmail.com> <20220425192036.p6awbyro2a2lp7bq@chazelas.org> <CAH+w=7Yz-usT3nbbOW8o-awgZ_EKYVDaM_VVhyKYwaiOdxRzzw@mail.gmail.com> <CAH+w=7bb+3T5MabhmCS9BwC7XmTxmydxQ5GLy7R7+6f6B7-=EA@mail.gmail.com> <1592299421.100566.1650961915601@mail2.virginmedia.com>

On Tue, Apr 26, 2022 at 1:32 AM Peter Stephenson
<p.w.stephenson@xxxxxxxxxxxx> wrote:
>
> Not sure how much difference it makes but to avoid additional system calls
> we could cache the result, invalidating it when we open a new file.

I considered that but there's no good way to isolate it to input.c ...
SHIN could be the same FD number across open/close/open, for example.

However, I think isset(SHINSTDIN) could be tested earlier in
shingetchar to reduce the number of system calls.

References:
- ZSH performance regression in 5.8.1.2-test
  - From: Jordan Patterson
- Re: ZSH performance regression in 5.8.1.2-test
  - From: Bart Schaefer
- Re: ZSH performance regression in 5.8.1.2-test
  - From: Stephane Chazelas
- Re: ZSH performance regression in 5.8.1.2-test
  - From: Bart Schaefer
- Re: ZSH performance regression in 5.8.1.2-test
  - From: Bart Schaefer
- Re: ZSH performance regression in 5.8.1.2-test
  - From: Peter Stephenson

Messages sorted by: Reverse Date, Date, Thread, Author