Re: ZSH performance regression in 5.8.1.2-test

[Jun T <takimoto-j@xxxxxxxxxxxxxxxxx>]

> 2022/04/28 4:54, Jordan Patterson <jordanp@xxxxxxxxx> wrote:
> 
>> zsh -xic exit 2>>(wc)
> 
> I get 13007 lines, 1534161 characters.

So your .zshrc (and anything loaded from it) is much smaller than the
tmp.txt I used, but:

>> Can you try the lseek() patch (in my previous post, 50115⁩)?
> Summary
>  'prefix/5.8.1/bin/zsh -i -c exit' ran
>    1.01 ± 0.05 times faster than 'prefix/5.8/bin/zsh -i -c exit'
>    1.13 ± 0.05 times faster than 'prefix/5.8.1.2-test-lseek/bin/zsh -i -c exit'
>   10.27 ± 0.41 times faster than 'prefix/5.8.1.2-test/bin/zsh -i -c exit'

it was about 10 times slower in 5.8.1.2-test (compared with 5.8),
and now with the Bart's lseek patch it is just about 10% slower.
I think 10% is acceptable.

> I needed to add a mode argument to the open in your lseek
> configure check.

Thanks!  I will use the following:
     open(tmpfile, O_CREAT, S_IRUSR)