Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [RFC PATCH 3/3] FAQ: sync newuser-install



On Sun, Sep 4, 2022 at 2:00 AM Felipe Contreras
<felipe.contreras@xxxxxxxxx> wrote:
>
> On Sat, Sep 3, 2022 at 6:13 PM Roman Perepelitsa
> <roman.perepelitsa@xxxxxxxxx> wrote:
> > On Sat, Sep 3, 2022 at 10:49 PM Felipe Contreras
> > <felipe.contreras@xxxxxxxxx> wrote:
>
> > > For starters this patch:
> > >
> > > https://www.zsh.org/mla/workers/2022/msg00875.html
> >
> > If I understand correctly, you propose to change this snipped in the guide:
>
> It's not a guide, it's a FAQ

Mea culpa.

> [...] the entry in the FAQ is "Why is my history not being saved?"

Do you believe that your change makes the answer better? If so, why?

I do not think it makes it better.

> >     HISTSIZE=200
> >     SAVEHIST=200
> >
> > With this:
> >
> >     HISTSIZE=200
> >     SAVEHIST=$HISTSIZE
> >
> > To me the original snippet looks better because it makes it clear that
> > the two parameters are independent.
>
> The user does not *need* to know that at this point, all he/she needs
> is an example that turns history save on. That's it.

Do you believe that from this it follows that your change is making
things better? Why?

I do not think that it follows.

Roman.




Messages sorted by: Reverse Date, Date, Thread, Author