Re: current git Fails to compile on Solaris 11 x86

[Oliver Kiddle <opk@xxxxxxx>]

Peter Stephenson wrote:
> The wrapper function just fits a generic form, so should stay void.
> It's as simple as it looks.  (I guess the line numbers were out in the
> code I was looking at so I misidentified what it was complaining about.)

Yes sorry, that fix is right. I still have my git branch and, looking
at the steps, I mistakenly copied the same form from the get*
functions when factoring out the common code for the
.zle.esc and .zle.sgr parameters.

Also the following fix is needed for this case:
  typeset -A .zle.hlgroups
  zmodload -i zsh/hlgroup
  : ${.zle.hlgroups[select]}
  export GREP_COLOR=${.zle.sgr[select]}

Oliver

diff --git a/Src/Modules/hlgroup.c b/Src/Modules/hlgroup.c
index f20f2c1f9..082762623 100644
--- a/Src/Modules/hlgroup.c
+++ b/Src/Modules/hlgroup.c
@@ -91,7 +91,8 @@ getgroup(const char *name, int sgr)
     if (!(v = getvalue(&vbuf, &var, 0)) ||
 	     PM_TYPE(v->pm->node.flags) != PM_HASHED ||
 	     !(hlg = v->pm->gsu.h->getfn(v->pm)) ||
-	     !(hn = gethashnode2(hlg, name)))
+	     !(hn = gethashnode2(hlg, name)) ||
+	     (((Param) hn)->node.flags & PM_UNSET))
     {
 	pm->u.str = dupstring("");
 	pm->node.flags |= PM_UNSET;