Re: [PATCH 1/1] zsh/random

[Oliver Kiddle <opk@xxxxxxx>]

Clinton Bunch wrote:
> I've made the recommended changes and removed the test file as the statistical
> analysis proved to be flawed, and I can think of no other test.

Thanks. I've now applied the change. Thanks for being patient with us
and I'm sorry that reviews and feedback have dragged on.

My test build does now include the following message:

  Including file Zsh/mod_random.yo
  mod_random.yo:55: No macro: int(...)

I'm guessing it needs LPAR() and RPAR() where zrand_int is documented.

And with clang, I get a couple of new compiler warnings:

  random.c:65:13: warning: variable 'val' set but not used [-Wunused-but-set-variable]
    65 |     size_t  val     = 0;
       |             ^
  random.c:66:14: warning: variable 'bufptr' set but not used [-Wunused-but-set-variable]
    66 |     uint8_t *bufptr = buf;
       |              ^

This is probably conditional on HAVE_ARC4RANDOM_BUF being defined.

Oliver