Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] Don't segfault when uniquifying hidden tied arrays
- X-seq: zsh-workers 55017
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: Philippe Altherr <philippe.altherr@xxxxxxxxx>
- Cc: Zsh hackers list <zsh-workers@xxxxxxx>
- Subject: Re: [PATCH] Don't segfault when uniquifying hidden tied arrays
- Date: Tue, 21 Jul 2026 13:54:46 -0700
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=OPi2xXY6aoAplMQaxX0r/iY16s0EpP1Fipe9DY7gUCg=; fh=RngAOd9wlRc8Glv1v2GOfDUnq2FsyrczungEY8JNfXY=; b=NDBfdgJPkJGGYjJgbmjoEyx4xReXPKjHNLT4FxxJVj+KlL7WwIVSmo4qYokRGwJBjF iJ4L9cVO8N+nqJCtkMqX40al5uiAIxe37UQniTOVUh7Z8I0osewirO+x91kWAO1WAAbv 9zpgCDsVqDqFIGoTOzEcesykCoV3qgqlejxWGYnq2GR88nzD62ks0noMDxBs1xr70j6d tmryQFBhayw4QgCyOagutLjEJBaUlYpqHxmyouSKu2jofAwUMViRFO/rUWKFQ2vY+PvJ t141i5q0vfXNbD9EcZPDJCpYDRdD/tG1jHdH5w0wwSP502BjbyRlWpn1yvNSVRNE7VoL AZeQ==; darn=zsh.org
- Arc-seal: i=1; a=rsa-sha256; t=1784667298; cv=none; d=google.com; s=arc-20260327; b=Q8wdee2mGs7LjiAfrArg836mpjASlbys7FpgwpW3Y1X7oaQkgH9GppGgpyC2qig41V MhOc/YDZBeIgSZkGsoywkWaPv81MRZH1RLu8bQZnkk1dkHStrsC9FHndlTbW60WMTs7x tdXfq4uPcMAc75364hfaGyB+uDaLfd9DUdeZWkzekcoNYjOoUVfOm7+NheDoneXQaq1U JXERYAAEGDaxvweDZVoW2TweJcA3Qeq9jRKgljxNTzh0N5smsFVXHvui5uvG6lQ6gljP 9tD2wHLZgJCIm7CqjfVaujgO60v4TfV8VIV2tPUfBWgCjnZCWQ33N87+KAopuZIsTeR/ HU4Q==
- Archived-at: <https://zsh.org/workers/55017>
- In-reply-to: <CAGdYchs4StAndjgG9aY1wTf8OvsaWnaJ5ONxRgr23QN6o3UuLQ@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <CAGdYchsZEkiDqMzwae6B0NhPG+mTGcSk+snEHjSj6iYwM-TC=Q@mail.gmail.com> <CAH+w=7aoKm=qAt0tMnM+Ls0eF0PvbK_OKqDSM22v38AzgFMxhA@mail.gmail.com> <CAGdYchs4StAndjgG9aY1wTf8OvsaWnaJ5ONxRgr23QN6o3UuLQ@mail.gmail.com>
On Mon, Jul 20, 2026 at 6:16 AM Philippe Altherr
<philippe.altherr@xxxxxxxxx> wrote:
>
> While pm->u.data is never NULL, the value assigned to x may be NULL but that's fine, then the code that follows simply does nothing; the function uniqarray immediately returns if its parameter is NULL.
The test case that fails if &nullarray is NOT returned by gsu.a->getfn is
Running test: add array to empty parameter
With your patch:
Src/zsh -f
% setopt typesettounset
% typeset -T VAR var
% () { typeset -i var; typeset -g -U VAR }
% echo $VAR
% echo $+VAR
0
% () { typeset -i var; typeset -g -U VAR='a:a:b' }
% () { typeset -i var; typeset -g -U VAR='a:a:b'; typeset -p VAR }
zsh: bus error Src/zsh -f
It crashes on "typeset -p" rather than on the assignment itself.
Without your patch, the above does not crash (but your original
example does).
Messages sorted by:
Reverse Date,
Date,
Thread,
Author