Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: D03 test hang on cygwin with latest sources



Phil Pennock wrote:
> On 2008-11-24 at 17:32 +0000, Peter Stephenson wrote:
> > Right, the behaviour isn't new.  It seems as if the subprocess is
> > reading EOF from the input.
> > 
> > % foo() { print $1; print hello >$1; [[ -e $1 ]] || print Ouch! }
> > % foo >(sleep 1; read foo || print Failed)
> > /proc/self/fd/12
> > Failed
> 
> ...% zsh -f
> redoubt% echo $ZSH_VERSION 
> 4.3.6
> redoubt% foo() { print $1; print hello >$1; [[ -e $1 ]] || print Ouch! } 
> redoubt% foo >(sleep 1; read foo || print Failed)
> /tmp/zshQCDdM0
> redoubt%
> 
> Looks like a regression after all.

Did you try it in 4.3.9?  I tried it on three different versions, before
and after 4.3.6, and got the same result.  If your system is doing
something different I'd like to find out what.

I *can* get the test to pass if I undefine PATH_DEV_FD and define
HAVE_FIFOS, so it looks like this is the way forward.  Some
investigation of why HAVE_FIFOS doesn't get define automatically would
be useful.

(I tried adding a "sync" pipe to getpipe() in the same way as in the
other pipe code, but it didn't seem to help.)

I'm also finding that I can read files with mode 000, so the [[ -r
... ]] test fails (but it's clearly doing the right thing, since "cat"
on the file works, too).  This may be because I have administrator
rights.  Unless some Cygwin expert can do this better, I'll apply the
following.

This is with Cygwin updated from the stable versions yesterday.

Index: Test/C02cond.ztst
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/C02cond.ztst,v
retrieving revision 1.22
diff -u -r1.22 C02cond.ztst
--- Test/C02cond.ztst	26 Feb 2008 20:50:13 -0000	1.22
+++ Test/C02cond.ztst	25 Nov 2008 09:54:00 -0000
@@ -94,6 +94,10 @@
   if (( EUID == 0 )); then
     print -u$ZTST_fd 'Warning: Not testing [[ ! -r file ]] (root reads anything)'
     [[ -r zerolength && -r unmodish ]]
+  elif [[ $OSTYPE = cygwin ]]; then
+    print -u$ZTST_fd 'Warning: Not testing [[ ! -r file ]]
+   (all files created by user may be readable)'
+   [[ -r zerolength ]]
   else
     [[ -r zerolength && ! -r unmodish ]]
   fi


-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070



Messages sorted by: Reverse Date, Date, Thread, Author