Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] Remove redundancies from `git` completion
- X-seq: zsh-workers 49373
- From: Oliver Kiddle <opk@xxxxxxx>
- To: Zsh hackers list <zsh-workers@xxxxxxx>
- Subject: Re: [PATCH] Remove redundancies from `git` completion
- Date: Thu, 02 Sep 2021 23:17:27 +0200
- Archived-at: <https://zsh.org/workers/49373>
- In-reply-to: <CAH+w=7ZiZFeJXV_G0RYQqMPB9BzQLEgJKtC0azftX-fM2Oy+0w@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <CAHLkEDt9=VdVFqvvwUfXb8HBO_uxZAnaS7f_gtBTSHy_XLMWsg@mail.gmail.com> <CAHYJk3SpQ1KibJtbjOvEputdVL3XEeJywKewk-xxEgZxgLXowg@mail.gmail.com> <CAHLkEDtu9ABHKC4JXn9s3DkKvh7me=s1x=EBV3ibr+dnUwbj9w@mail.gmail.com> <CAHYJk3Qf5W2TY0u03bS7wUzR9Q8iXtwmpDRG8o8nTRCaBgMT1g@mail.gmail.com> <CAHLkEDu=hm77q1idtFg5PhPeh9FmxrvPOgrutz-Eaz0UBM_g9Q@mail.gmail.com> <20210901140327.GB27958@tarpaulin.shahaf.local2> <CAH+w=7aB4QALHV0X5Q0fHeQQw=q+a9yP5-Kv7rRn5iOd131xhg@mail.gmail.com> <CAHLkEDvnETmxUWen-o=oZtxDpfsZc3zNH2940j_6=7r4w=L+Fw@mail.gmail.com> <55401-1630615867.120247@EZKa.ra6F.k6mM> <CAH+w=7ZiZFeJXV_G0RYQqMPB9BzQLEgJKtC0azftX-fM2Oy+0w@mail.gmail.com>
Bart Schaefer wrote:
> On Thu, Sep 2, 2021 at 1:51 PM Oliver Kiddle <opk@xxxxxxx> wrote:
> >
> > This particular test was rather annoying before $functions_source
> > existed because it made it more difficult to fully reload all _git
> > functions.
>
> I can't tell if you're arguing for simply removing the test, or for
> exploding all the functions into their own files (which I think would
> necessitate another layer of subdirectory, just for sanity).
For the sake of sanity (and consistency), I'd keep it in the single
file.
I wouldn't object to removing the tests, either wholesale or selectively.
But I'm not inclined to be proactive about removing them either.
Oliver
Messages sorted by:
Reverse Date,
Date,
Thread,
Author