Re: [PATCH] use clear-to-end to reduce trailing whitespace

[Oliver Kiddle <opk@xxxxxxx>]

On 19 Jan, Daniel Colascione wrote:
> The attached new version of the patch should handle right prompts too. I
> tested it with both zero and non-zero right prompt margins.

Aside from right prompts, the other thing that comes to my mind
as needing to be tested is the ellipses that are printed when the
command-line is too big for the terminal.

After resizing the terminal to not be too large and then filling it with
text, I see issues with your patch. With the first patch, backspace on
a line that was longer that the terminal is wide caused issues. With
the second patch, I notice issues if I fill the command-line with more
lines than will fit. Then when I move the cursor up, at some point it
loses the prompt and replaces it with some of the text from the line.
I would speculate that this is caused by the terminal scrolling by one
line when that's not wanted. I'm mostly either using urxvt or foot.

I would also suggest applying a background colour to the entire text
entry area as that can show up problems that would not otherwise be
present or apparent.

I don't as such have objections to removing code that's only there for
terminals that have long ago ceased to be used.

Oliver