Re: [PATCH] tests: improve readability

[Mikael Magnusson <mikachu@xxxxxxxxx>]

On Sat, Jun 6, 2026 at 12:33 AM Philippe Altherr
<philippe.altherr@xxxxxxxxx> wrote:
>
> On Fri, Jun 5, 2026 at 7:50 PM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
>>
>> Rather than make a lot of changes to the test output itself, maybe
>> create something like Philippe's sed as a coprocess to filter the
>> output (and then using that only for interactive sessions).
>
>
> Maybe that's the best way to go for now. The current patch would disrupt parts of my test script even though it's pretty simple (some sed expressions would no longer do their job). Chances are that many other existing workflows would be affected.

I don't think we have ever guaranteed anything about "make test" than
success meaning success. It should be a pretty small adjustment to
your scripts for you and the possibly ones of people having similar
scripts.

> Adding a new test script instead of modifying the existing ones has the advantage that no existing workflow will be affected and it allows us to iterate as much as we want. In addition to that it also allows us to introduce a more user friendly way to run tests. For example, my script allows me to run "zsh-test -c A" instead of "make && make check ZTST_continue=1 TESTNUM=A".
>
> My script (shown below) already does a pretty good job but if we decide to add something like that, I would replace the sed call with zsh code and try to implement the things done in the patch but not in my script.

The disadvantage is that it will inhibit the very nice animation of
the W02 test.

If you ask me, the advantages of making the output nicer by default
outweigh any minor disadvantages of having to update a fragile sed
script.

-- 
Mikael Magnusson