Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] tests: improve readability
- X-seq: zsh-workers 54747
- From: dana <dana@xxxxxxx>
- To: "Mikael Magnusson" <mikachu@xxxxxxxxx>
- Cc: "Philippe Altherr" <philippe.altherr@xxxxxxxxx>, "Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxx>, zsh-workers@xxxxxxx
- Subject: Re: [PATCH] tests: improve readability
- Date: Thu, 11 Jun 2026 02:04:42 +0000
- Archived-at: <https://zsh.org/workers/54747>
- Feedback-id: i9be146f9:Fastmail
- In-reply-to: <CAHYJk3Q5OfQHDWmDs6A=k4WD_F-3YcLvr+n85xmXhPMvFR=HkQ@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <e7c0c05f-988f-4837-ad14-6157e75ca5ea@app.fastmail.com> <783256270.579404.1780648068574@mail.virginmedia.com> <CAGdYcht84XMPPfUBbrvubmLkV5B32eXt+PL8FztDxsiPSU=qDg@mail.gmail.com> <CAGdYchsxjwbG8w_se=_YPKsTbB0WNy+TNpuV2bHQT6uJbFRakA@mail.gmail.com> <CAH+w=7a4Nz_EWepCwQeRB9ip95d6ecgJBA5Z-_jmmKEgN8Bh5A@mail.gmail.com> <CAHYJk3SSkO=Mw4tRukWtYnqaPzgD7pC3dUqDyzpo7Na=g-xuvw@mail.gmail.com> <CAGdYchuf4UwFpaRAfC26AjP18gCMyxdL3__481DOLQSjAQMDSg@mail.gmail.com> <CAHYJk3Q5OfQHDWmDs6A=k4WD_F-3YcLvr+n85xmXhPMvFR=HkQ@mail.gmail.com>
On Fri 5 Jun 2026, at 23:18, Mikael Magnusson wrote:
> If you ask me, the advantages of making the output nicer by default
> outweigh any minor disadvantages of having to update a fragile sed
> script.
oliver and mikael were in favour of this and tbh i agree with the quote
so i've committed it
as mentioned i tried to account for non-interactive use, but if the
change causes any problems there, or if it's too annoying in general,
please lmk and i'll fix it
re: philippe's suggestions, i agree with several of them, so maybe i'll
revisit later. but i do have two general concerns:
- i feel like bold is problematic. it means different things in
different terminals so it's hard to use it in a way that looks good
for everyone, especially next to or in conjunction with colours
- i think there is a risk of making it *too* colourful. i have this
issue with the default colour settings in gcc -- it colours every
single bit of the output so i have trouble finding where the actual
errors are in projects that have a lot of warnings. i also think that
when you see the same colours every time they tend to lose their
visual weight
dana
Messages sorted by:
Reverse Date,
Date,
Thread,
Author